docs(#1794): remove unnecessary imply
#1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@JayKan Just needs a rebase and we'll merge. Thanks! |
| @@ -141,7 +141,7 @@ export class Observable<T> implements Subscribable<T> { | |||
| } else { | |||
| // if there is NO subscription, then we're getting a nexted | |||
| // value synchronously during subscription. We can just call it. | |||
| // If it errors, Observable's `subscribe` imple will ensure the | |||
There was a problem hiding this comment.
btw I believe this was intended to be
Observable's subscribe simply will ensure the
but it reads better without it, so 👍
|
LGTM, thank you! |
|
No problem at all @jayphelps. I should have dropped by and say hi to both you and ben at the Angular meet-up event... |
|
@JayKan indeed! Next time 🍻 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing typos